search

loopbackio / loopback-connector-redis

EXPERIMENTAL: Redis connector for LoopBack.
http://loopback.io/doc/en/lb2/Redis-connector.html
Other
36 stars 46 forks source link

Settings bug fix when passing an host without a port #57

Closed TwistedLogic closed 6 years ago

TwistedLogic commented 6 years ago

The redis client doesn't get created when only the host setting is passed.

raymondfeng commented 6 years ago

@TwistedLogic Thank you for the patch. Let me suggest an improvement.

Considering now redis support redis.createClient([options]), we don't have to treat port/host specially and the settings should be passed in as options.

TwistedLogic commented 6 years ago

I see, thanks. I'm now still using dataSource.settings.options to avoid breaking changes.