add check on process.env.HOST in index.ts.ejs file

atefBB commented 3 months ago

process.env.HOST may be undefined so we need to add a check on it !

Checklist

[ ] DCO (Developer Certificate of Origin) signed in all commits
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Documentation in /docs/site was updated
[ ] Affected artifact templates in packages/cli were updated
[ ] Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9503680510

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.287%

Totals
Change from base Build 9419955538:	0.0%
Covered Lines:	9566
Relevant Lines:	12465

💛 - Coveralls

atefBB commented 3 months ago

DONE @dhmlau !

dhmlau commented 3 months ago

Thanks @atefBB. There seems to be some linting issue with the commit messages.

⧗   input: Merge bb408e97191bd9d441dd4a9392c87036df23554c into b0e4a869679b8bb4ca2c48c233348d582dd4752a

✔   found 0 problems, 0 warnings
⧗   input: Update packages/cli/generators/app/templates/src/index.ts.ejs

Co-authored-by: Diana Lau <dhmlau@ca.ibm.com>
Signed-off-by: Atef Ben Ali <atefBB@users.noreply.github.com>
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: Update index.ts.ejs

`process.env.HOST` may be `undefined` so we need to add a check on it !

Signed-off-by: Atef Ben Ali <atefBB@users.noreply.github.com>
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Error: Process completed with exit code 1.

Could you please squash the commits? The commit message could be something like:

fix(cli): add check on process.env.HOST

Please see our commit guideline for details. Thanks.

atefBB commented 3 months ago

ok ! I'll do !

atefBB commented 3 months ago

I think it's DONE @dhmlau !

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9582807776

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.772%

Totals
Change from base Build 9574120057:	0.0%
Covered Lines:	9566
Relevant Lines:	12465

💛 - Coveralls

dhmlau commented 3 months ago

Thanks @atefBB. Your PR has been merged! 🎉

atefBB commented 3 months ago

thx @dhmlau

loopbackio / loopback-next