bajtos
commented
5 years ago @GuerricPhalippou thank you for opening the issue. For reference, here is our original discussion on StackOverflow: https://stackoverflow.com/q/52833380/69868
As I wrote on StackOverflow, I think that ideally, session handling should be implemented as a new Sequence action - see Sequence docs.
class MySequence {
// skipping constructor with dependencies to be injected
async handle(context: RequestContext) {
try {
// the following line is new
const session = this.restoreSession(context);
// the default sequence continues here
const route = this.findRoute(context.request);
const params = await this.parseParams(context.request, route);
const result = await this.invoke(route, params);
await this.send(context.response, result);
} catch (error) {
await this.reject(context, error);
}
}
}The sequence action restoreSession should:
- check if there are any session cookies present in the request
- load the session if a cookie was provided, maybe create a new one otherwise?
- bind the session in our Context so that other places like controllers can receive the session via Dependency Injection
The v4 complying solution would be a sequence action, but it doesn't exist yet in
RestBindings.SequenceActions. Have a sequence action that retrieves cookies information and make it available to the app via context and dependency injection.
On of our design goals for LoopBack 4 was to make it easy for 3rd party developers to contribute extensions and thus keep the framework modular. IMO, session handling should live in a new module independent from @loopback/rest.
I am expecting there will be many users looking for HTTP session support, therefore it makes sense to me to keep the session extension inside loopback-next monorepo.
@GuerricPhalippou would you like to contribute this session extension yourself? I am happy to help you along the way.
GuerricPhalippou
lazaro9318
mrmodise
malek0512
L-Luciano
pure180
raymondfeng
stale[bot]
wdrdres3qew5ts21
shailendramonu
damiansimon2
Feature proposal
Since middlewares are internally used and not exposed to developers, there is no possible way to implement stateful requests, as it was done with the
express-sessionmiddleware before v4.Current Behavior
The v4 complying solution would be a sequence action, but it doesn't exist yet in
RestBindings.SequenceActions.Expected Behavior
Have a sequence action that retrieves cookies information and make it available to the app via context and dependency injection