loopbackio / loopback-next

LoopBack makes it easy to build modern API applications that require complex integrations.
https://loopback.io
Other
4.96k stars 1.07k forks source link

Add CODEOWNERS for automatically requests reviews from code owners #517

Closed dhmlau closed 7 years ago

dhmlau commented 7 years ago

New feature in github allows us to specify the owner of the repo. https://github.com/blog/2392-introducing-code-owners

Since each package might have different set of codeowners, I'm proposing the following breakdown:

*  @bajtos @raymondfeng #for overall
packages/authentication/*  <<some ids>>
packages/context/*  <<some ids>>
...

Related to https://github.com/strongloop-internal/scrum-apex/issues/278

bajtos commented 7 years ago

+1 from me. If I understand the format of CODEOWNERS file correctly, then I think we need to duplicate "overall" owners in each package-specific line.

*  @bajtos @raymondfeng

packages/context/* @bajtos @raymondfeng @somebodyelse
dhmlau commented 7 years ago

PR has landed. Closing it.