search

loopbackio / loopback4-extension-grpc

gRPC Extension for LoopBack 4
Other
18 stars 8 forks source link

The Auto-generated proto.ts should have async methods that returns promises #31

Closed lhr0909 closed 6 years ago

lhr0909 commented 6 years ago

We were evaluating if we could expose endpoints as gRPC endpoints, and found that the .proto.ts part of the code during auto-generation is not building methods that returns a promise. Currently we can have synchronous returns, but in the NodeJS world, we need these controller methods to be async so we can fetch data and return.

lhr0909 commented 6 years ago

I am in the process of smoothing out the PRs. I will make sure to have as little changes as possible.

lhr0909 commented 6 years ago

Closing this because I think this belongs to @mean-expert/protoc-ts lib