search

loopbackio / loopback4-extension-grpc

gRPC Extension for LoopBack 4
Other
18 stars 8 forks source link

Setup starter and ci. #5

Closed jonathan-casarrubias closed 7 years ago

jonathan-casarrubias commented 7 years ago

Implemented a vanilla version of the loopback extension starter, made some tweaks and added travis & appveyor config files.

Also added .github templates from loopback-next repo.

raymondfeng commented 7 years ago

@jonathan-casarrubias Good start. Do you want to clean up the log related stuff before we merge it?

jonathan-casarrubias commented 7 years ago

@raymondfeng absolutely, actually I'm almost done with that lol... I thought having a vanilla version from extension starter (and working) would be a good idea, but I'm definitely keen to merge until I remove all the starter examples.

jonathan-casarrubias commented 7 years ago

@raymondfeng I already did that, also I sent some progress I have for this extension..

I added a ServerProvider and a simple test for that, also some typings... I did squach and rebased master so everything should be in order.

Cheers Jon

jonathan-casarrubias commented 7 years ago

Yeah we might do that, these docs are helping me during the ramp up / learning process, so I don't need to go to the starter repo and read those.

But, again we might want to clean that up too and avoid confusions

VMois commented 7 years ago

Okay, so basically you want to keep it for now and later clean them? @jonathan-casarrubias

jonathan-casarrubias commented 7 years ago

@VMois yeah basically, but is not a must... just a time saver for now, but definitely we need to get rid of that info ASAP.

I propose the following.... I'm working in a provider and in a decorator as POC for now, when I'm done with these 2, I can change the README docs from those 2 folders for information that actually is related to this project.

Does that sounds fair?

VMois commented 7 years ago

Okay, it's great. Good work with starter) @jonathan-casarrubias

jonathan-casarrubias commented 7 years ago

@VMois @raymondfeng I cleaned up unrelated docs and logger stuff, also added a README for the decorator I developed today and of course the decorator and a unit test for that.

Cheers Jon

jonathan-casarrubias commented 7 years ago

Closing this PR for now, until I create unit tests for the second approach