chore: added new parameter "textTrim" in XMLHandler

loopbackio / strong-soap

SOAP driver for Node.js (A complete rewrite of node-soap)

Other

391 stars 163 forks source link

chore: added new parameter "textTrim" in XMLHandler #684

Closed Apkovy closed 9 months ago

Apkovy commented 9 months ago

Description

Added new boolean parameter "textTrim" to options object in XMLHandler constructor. This new parameter is used in p.ontext method. The default value is true for backward compatibility.

Refers to issue #610

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7687741153

0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 84.636%

Totals
Change from base Build 7663771488:	-0.02%
Covered Lines:	2894
Relevant Lines:	3249

💛 - Coveralls

achrinza commented 9 months ago

LGTM. Just need to squash into a single commit to fix the commit lint error.

Or if preferred, we can also assist to do that on our end on your behalf.

Apkovy commented 9 months ago

Or if preferred, we can also assist to do that on our end on your behalf.

Yes, perfect. Thanks.