loopbackio / strong-soap

SOAP driver for Node.js (A complete rewrite of node-soap)
Other
390 stars 159 forks source link

chore: switch to httpntlm and fix flaky test #717

Closed toddtarsi closed 5 months ago

toddtarsi commented 5 months ago

Description

Switches httpntlm-maa to the supported thing. Fixed the test suite by repairing the bad async bits in the prior test to the reporting test.

Related issues

Checklist

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8316466170

Details


Files with Coverage Reduction New Missed Lines %
src/http.js 1 93.02%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8272050559: 0.04%
Covered Lines: 2893
Relevant Lines: 3247

💛 - Coveralls
toddtarsi commented 5 months ago

@raymondfeng @achrinza - Would one of you be able to look at this PR sometime this week? It deals with a couple Soc-2 issues around request and tough-cookie I think.

achrinza commented 5 months ago

Thanks for the PR and test fixes! Your changes have been merged 🎉

toddtarsi commented 5 months ago

Yay! Thank you @achrinza !

dhmlau commented 5 months ago

strong-soap@4.0.4 is just released.

toddtarsi commented 5 months ago

Woohoo! Thanks @dhmlau