search

loophole / cli

Loophole. Instant hosting, right from your local machine. CLI.
https://loophole.cloud
MIT License
166 stars 17 forks source link

Loophole doesn't reconnect after a network outage #259

Open jarble opened 6 months ago

jarble commented 6 months ago

My wireless network connection is occasionally disrupted. Whenever this happens, Loophole attempts to reconnect 5 times and then quits.

Instead of quitting when the network goes down, should Loophole stay open and attempt to reconnect when the network is available again?

0x7f commented 6 months ago

Hi @jarble we have a hard-coded retry count here: https://github.com/loophole/cli/blob/06767ef30bebf6095f1d93f6552d4727cc7ce241/internal/app/loophole/loophole.go#L102-L120 We could either always make it retry forever, or make the retry configurable via cli argument. @Morishiri what would you prefer?

Morishiri commented 6 months ago

let's make it configurable via cli, with 0 being infinity

jarble commented 5 months ago

@Morishiri and @0x7f If this becomes configurable, should it be "infinity" by default?

xfearx1 commented 4 weeks ago

Hello, will this be a thing? My network is also a little unstable, and sometimes it disconnects in the middle of the night, then for me find out just in the morning it was down for several hours.