Fix/cache operation - Githubissues

loophp / collection

A (memory) friendly, easy, lazy and modular collection class.

https://loophp-collection.rtfd.io/

MIT License

721 stars 35 forks source link

Fix/cache operation #319

Closed drupol closed 10 months ago

drupol commented 11 months ago

This PR:

[x] Relates to https://github.com/loophp/collection/issues/264#issuecomment-1808384744
[x] Fix the cache operation
[ ] Provide ...
[ ] It breaks backward compatibility
[ ] Is covered by unit tests
[ ] Has static analysis tests (psalm, phpstan)
[ ] Has documentation
[ ] Is an experimental thing

cc @rela589n

drupol commented 10 months ago

Good for you @AlexandruGG ?

AlexandruGG commented 10 months ago

Good for you @AlexandruGG ?

Will review in a bit!

github-actions[bot] commented 10 months ago

Since this pull request has not had any activity within the last 5 days, I have marked it as stale. I will close it if no further activity occurs within the next 5 days.

drupol commented 10 months ago

Indeed, not yet :( I definitely think that this operation should be reworked totally and the parameter removed.

I'll give it a shoot asap !