search

loopier / animatron

Animatron for Godot 4.x <
15 stars 1 forks source link

Duplicate functions for resource loading? #32

Closed loopier closed 5 months ago

loopier commented 5 months ago

I think we have implemented loading assets twice:

https://github.com/loopier/animatron/blob/12a439da884cc3d2ca77288274d54e310668a063/CommandInterface.gd#L606

https://github.com/loopier/animatron/blob/12a439da884cc3d2ca77288274d54e310668a063/asset_helpers.gd#L149

in CommandInterface.loadAnimationAssets() we call asset_helpers for sprites and CommandInterface for image sequences.

We should decide on just one. I'm fine with asset_helpers which I think was implemented by you.

loopier commented 5 months ago

Actually, that wasn't true, they are both calling asset_helpers in the end.