search

loopindex / ckeditor-track-changes

Track changes plugin for CKEditor, based on ICE (track changes for TinyMCE).
www.loopindex.com
Other
51 stars 55 forks source link

ice is not defined #36

Closed meyeet closed 9 years ago

meyeet commented 9 years ago

I'm trying to get the track changes plugin to work with the Primefaces CKEditor Extension. The track changes toolbar loads but I get errors in the console window when the plugin is initializing:

ReferenceError: ice is not defined this._tracker = new ice.InlineChangeEditor(iceprops); plugin.js (line 932, col 4)

My setup is: lite_master (as of 11/4/2014) primefaces-5.1 primefaces-extensions-2.1.0 resources-ckeditor-2.1.0 IE 9 and Firefox 31

imdfl commented 9 years ago

Hi Meyeet, Here's what I did in order to reproduce the problem:

  1. Grab a zip of the latest master from github
  2. Install a fresh copy of ckeditor 4.4 in a new folder
  3. Copy the dist/lite folder from step 1 into the plugins folder of step 2
  4. Edit config.js to add lite as an extra plugin
  5. run some cke samples in FF and chrome.

In all the samples, lite showed up and functioned well with no console errors. I repeated the test with the src/lite folder from the zip (same sources but unminified). Same result.

I'd be happy to help if you provide a recipe for reproducing your problem. Naturally I prefer not to duplicate your setup, it's best if you can repro with vanilla cke. If not possible, please post here all the missing includes and other problems your developer console may display while loading LITE.

meyeet commented 9 years ago

No problem. I'm writing a JSF application that uses PrimeFaces and the PrimeFaces Extensions CKEditor. The following steps should get you setup:

  1. Download PrimeFaces 5.1 (http://search.maven.org/remotecontent?filepath=org/primefaces/primefaces/5.1/primefaces-5.1.jar)
  2. Download PrimeFaces-Extensions (http://search.maven.org/remotecontent?filepath=org/primefaces/extensions/primefaces-extensions/3.0.0/primefaces-extensions-3.0.0.jar)
  3. Download Resources-CKEditor (http://search.maven.org/remotecontent?filepath=org/primefaces/extensions/resources-ckeditor/3.0.0/resources-ckeditor-3.0.0.jar)
  4. Download Commons-lang3 (http://commons.apache.org/proper/commons-lang/download_lang.cgi)
  5. Download Gson 2.3 (http://search.maven.org/remotecontent?filepath=com/google/code/gson/gson/2.3/gson-2.3.jar)
  6. Download JSF2.2 (https://maven.java.net/content/repositories/releases/org/glassfish/javax.faces/2.2.8/javax.faces-2.2.8.jar)
  7. update the resource-ckeditor-3.0.0.jar to include the LITE plugin and the updated config.js
  8. Setup a new JSF application including the above libs.
  9. create a new page that has the primefaces ckeditor extension:
<html xmlns="http://www.w3.org/1999/xhtml"
    xmlns:h="http://java.sun.com/jsf/html"
    xmlns:f="http://java.sun.com/jsf/core"
xmlns:p="http://primefaces.org/ui"
xmlns:pe="http://primefaces.org/ui/extensions">

<h:head>
    <title>Track Changes Plugin Testing</title>
</h:head>

<h:body>
<div>
<pe:ckEditor></pe:ckEditor>
</div>
</h:body>
</html>
  1. Deploy and Run. The LITE toolbar is shown on CKEditor but the buttons do not have tooltips, are not active, and just spit out error messages to the web browser's debug console.

Thanks for looking into this for me.

loopindex commented 9 years ago

Hi, thanks for the update.

The setup you've described is a bit too complex for our normal bug reproduction process. Here's our counter offer: You can set up the environment you've described and use the full (unminified) lite sources in the plugins folder. Put together a web page which demonstrates the problem and send us the link. We'll browse the page with the standard dev tools and try to figure out why lite doesn't load properly.

Cheers,

David, LoopIndex development