Make animate optional via data-slider-* attribute

[maartenvg]

I was missing a data-slider-animate to toggle animation, so I created it for you.

It includes edits for all three formats, coffeescript, js and min.js

[loopj]

Hey Maarten, thanks for the pull request.

Could you ensure that this setting defaults to true for backwards compatibility? If so, I'd be happy to merge.

Best

• James

[maartenvg]

No problem!

[maartenvg]

@loopj I added a commit that checks for the attribute.

[maartenvg]

I fetch/rebased the changes of todays commits, so now it should merge properly again

[loopj]

Thanks @maartenvg. I've noticed that while you've made a new setting, nothing actually checks the value of the setting, so your changes don't do anything.

[loopj]

Also, might i suggest an alternative approach for checking for "true/false" values from a data tag:

settings.animate = if $el.data("slider-animate")? then $el.data("slider-animate") else true

The ? operator in coffeescript is great for checking for a non-null value.

[maartenvg]

settings.animate is an existing setting that is used throughout the script to toggle animations. You implemented that yourself ;)

The only thing I did, was to make that setting editable via data-slider-animate, instead of only being able to set it via constructor initialization (losing all the pretty unobtrusive fun).

Thanks for the ? tip, I'll use that instead. I'm still a bit rusty on coffee-script.

[loopj]

I totally forgot I already had settings.animate!

[loopj]

Thanks @maartenvg