Closed maartenvg closed 11 years ago
I am SO HAPPY! Perfect!!!
Seriously, put a tip jar on your webpage.
On Apr 11, 2013, at 9:29 PM, Maarten van Grootel notifications@github.com wrote:
In issue #7 several people requested highlighting the track up to the handle/grabber.
That was a good idea that I like too, and so I've implemented it as an optional setting (default = off). Styles that fit the current themes are included and adjustable, and I've updated the demo-page.
I've kept it as DRY as possible, because there was some repetition going on.
This is how it looks when you add data-slider-highlight="true" to an input field.
You can merge this Pull Request by running
git pull https://github.com/maartenvg/jquery-simple-slider highlight-track-up-to-handle Or view, comment on, or merge it at:
https://github.com/loopj/jquery-simple-slider/pull/25
Commit Summary
Optionally highlight track up to the handle - fixes #7 Better option checking in case somebody changes the default option Add examples of highlight to demo-page File Changes
M css/simple-slider-volume.css (11) M css/simple-slider.css (15) M demo.html (7) M js/simple-slider.coffee (66) M js/simple-slider.js (79) M js/simple-slider.min.js (2) Patch Links:
https://github.com/loopj/jquery-simple-slider/pull/25.patch https://github.com/loopj/jquery-simple-slider/pull/25.diff
Thanks @maartenvg, I was planning on implementing this at some point and you've implemented it exactly how I would. Awesome!
In issue #7 several people requested highlighting the track up to the handle/grabber.
That was a good idea that I like too, and so I've implemented it as an optional setting (default = off). Styles that fit the current themes are included and adjustable, and I've updated the demo-page.
I've kept it as DRY as possible, because there was some repetition going on.
This is how it looks when you add
data-slider-highlight="true"
to an input field.