search

looplab / eventhorizon

Event Sourcing for Go!
Apache License 2.0
1.57k stars 196 forks source link

Remove duplicate definition of MongoDB in docker-compose file #378

Closed zdraganov closed 2 years ago

zdraganov commented 2 years ago

Description

Cannot start the Todo MVC example application

Affected Components

Related Issues

377

Solution and Design

Remove the duplicate MongoDB service from docker-compose file

Steps to test and verify

  1. Navigate to ./examples/todomvc
  2. Run docker-compose up
maxekman commented 2 years ago

Not sure we want to remove that, it’s the way to run a MongoDB that works for local dev. Instead start the TodoMVC with make.

maxekman commented 2 years ago

I think we should instead change this line: https://github.com/looplab/eventhorizon/blob/main/examples/todomvc/Makefile#L9

zdraganov commented 2 years ago

Ah, yeah. If it's started using make command instead of single docker-compose up, then it's fine. Closing