search

looplab / eventhorizon

Event Sourcing for Go!
Apache License 2.0
1.57k stars 196 forks source link

Switch to OpenTelemetry #392

Open janiskemper opened 1 year ago

janiskemper commented 1 year ago

Is your feature request related to a problem? Please describe. OpenTracing is deprecated in favor of OpenTelemetry (https://github.com/opentracing/specification/issues/163)

Describe the solution you'd like Switch to OpenTelemetry.

marcwickenden commented 1 year ago

I have this (kinda) working on my fork at https://github.com/marcwickenden/eventhorizon/tree/opentelemetry. I haven't submitted a PR because it's not fully tested yet (not sure if propagation is reliable) and I've also implemented it in a way that is not backwards compatible with the existing version. Might be useful though?

janiskemper commented 1 year ago

Thanks a lot @marcwickenden ! That will help me getting started :+1:

maxekman commented 1 year ago

Great idea! I would be glad to accept a PR!

jefflinse commented 8 months ago

Hey @janiskemper, just curious if you've made any progress on this or would like help? Would be great to see OTEL support in EventHorizon.

janiskemper commented 8 months ago

Hey, yes I actually worked on it and did make some progress, but never reached the state that it would be possible to make a PR in this project.

I stopped working on it eventually because I realized that my use case was not fully covered by this project. Therefore, I shifted my work a bit away. Currently, I am focusing on very different topics, so I won't be able to continue with this. Sorry!