search

looplab / logspout-logstash

A minimalistic adapter for github.com/gliderlabs/logspout to write to Logstash
Apache License 2.0
293 stars 133 forks source link

Fields and defaults #37

Closed iljaweis closed 7 years ago

iljaweis commented 7 years ago

This adds a new configuration option LOGSTASH_FIELDS for setting any logstash fields, and uses the values of LOGSTASH_FIELDS and LOGSTASH_TAGS for the logspout-logstash as a default for all containers if not set there (see #35).

maxekman commented 7 years ago

Do you still want this? If so please respond to the comments.

iljaweis commented 7 years ago

I was off work during the holidays. Yes, I still would like those changes merged. Working on it now.

iljaweis commented 7 years ago

There are already tests for the fields feature, do you have any specific cases to test in mind?

maxekman commented 7 years ago

No worries, I just did a review of the issues and PRs and wanted to notify the authors. Great that you are picking it up again!

I must have missed the testes, they seem to cover it well.

iljaweis commented 7 years ago

Great. :-) I have since pushed a commit that solves your other comments.

iljaweis commented 7 years ago

Yes!

iljaweis commented 7 years ago

Thanks. ;-)