Update dependencies to allow both HTTPlug 1.x and 2.x

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API

MIT License

14 stars 15 forks source link

Update dependencies to allow both HTTPlug 1.x and 2.x #101

Closed ste93cry closed 5 years ago

ste93cry commented 5 years ago

Simple PR to update the composer.json to remove some dependencies that should not be required by this library and others that were unused. I've also updated the dependencies to allow installing the newest version of HTTPlug. Unfortunately we cannot typehint against PSR-17/PSR-18 if we don't drop support for HTTPlug 1.x and I'm not sure we should because there are many other packages requiring such version, so it may be possible that someone using this library won't be able to install it if some other dependency it relies on doesn't allow HTTPlug 2

coveralls commented 5 years ago

Coverage remained the same at 18.261% when pulling cf5f94a822e504560d8a5544e78707cdda542fac on ste93cry:feature/allow-httplug-2 into 0489970efdb22b552d39e008b6679080339af4a7 on loopline-systems:develop.

mavimo commented 5 years ago

@ste93cry nice work! Should we consider to add some more info in the README to explain how to setup the client based on a httplug version?

Something like:

## Setup client
### Using httplug 1.x
...
### Using httplug 2.x
...
## Use client to create a lead
...

IMHO should be very useful for new users

ste93cry commented 5 years ago

I don't know if it makes sense because depending on which HTTP client/adapter and PSR-7 factories package users will choose to use, Composer will automatically install HTTPlug 1.x or 2.x by resolving their dependencies, so there is not really something to document