search

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API
MIT License
14 stars 15 forks source link

Prevent the request body parameters to be put in the query string #105

Closed ste93cry closed 5 years ago

ste93cry commented 5 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
License MIT

This PR splits the query parameters from the body parameters of a request fixing a bug that was copying in the query string all the parameters of a POST/PUT/PATCH/DELETE request. Since I've added a new parameter to the public API these changes are breaking, however since we're still in 0.x Semver specs allow any kind of breaking change to happen even between minor versions

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.02%) to 18.182% when pulling cebd888f25064461150c4e4e88ec4dec5324025a on ste93cry:fix/no-post-params-in-querystring into 7ed2b8aee04181c655e96b3903353765ddc413cc on loopline-systems:develop.