search

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API
MIT License
14 stars 15 forks source link

add SMS activity #34

Closed wodka closed 6 years ago

wodka commented 6 years ago
mickadoo commented 6 years ago

@wodka thanks for the PR

Do you think you could add a description? I know the title is pretty clear, but you'd be surprised how a simple introduction can help reviewers and people looking back at this PR in the future.

I also see there are few changes unrelated to SMS activities, if these are necessary for the SMS change maybe you could outline why in the description, or if not then it might be better to focus just on one thing here.

wodka commented 6 years ago

@mickadoo good idea - moved all the other changes to https://github.com/loopline-systems/closeio-api-wrapper/pull/35

wodka commented 6 years ago

@mickadoo just changed listSms to getSmss

mickadoo commented 6 years ago

@wodka it looks like you rebased again and the commit message doesn't really reflect all the changes in this PR. Could you rebase and add a more accurate message?

wodka commented 6 years ago

@mickadoo sry - used the commit message from the other pull request - updated it now

mickadoo commented 6 years ago

Looks good, thanks @wodka