search

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API
MIT License
14 stars 15 forks source link

refs #56: remove code climate reporting #57

Closed mavimo closed 6 years ago

mavimo commented 6 years ago

Closes #56

I've not access to codeclimate settings so I'm not sure on how to configure it, maybe @marczahn can help us :)

https://docs.codeclimate.com/docs/github#section-show-me-how

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 22.893% when pulling b89eeac9fedfe1851ee0969c8d2f81043c68f17a on feature/56-fix-code-climate-report-tool into efaafb5a39510539603e247a442ff35da781819b on develop.

mickadoo commented 6 years ago

@mavimo the reason I was stalling a bit on this is that codeclimate asks for a hell of a lot of permissions.

image

To me that sounds waaay too much, I see there's an issue about it too: https://github.com/codeclimate/codeclimate-services/issues/73

This would give write access to a lot of work repos, which I don't like the idea of at all. What do you think?

mavimo commented 6 years ago

@mickadoo I agree, maybe we can consider to drop this integration from our codebase and introduce some more checks using OSS tools (eg phpstan, phpmd, phpcs, infection, ...), if there is an agreement on it I'll do in the next days.

mickadoo commented 6 years ago

@mavimo I'm fine with it. Something like code climate is cool to have, but not critical either. If we can achieve something similar with those tools you mentioned it'd be great.

mavimo commented 6 years ago

@mickadoo codeclimate removed

mickadoo commented 6 years ago

@mavimo thanks!

mickadoo commented 6 years ago

@mavimo before you close this can you update the PR title?

mavimo commented 6 years ago

@mickadoo done