search

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API
MIT License
14 stars 15 forks source link

Standardize and refactor the API handlers #92

Closed ste93cry closed 6 years ago

ste93cry commented 6 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Tests pass? yes
License MIT

This PR is an initial refactoring of the classes that handle the APIs by exposing common methods to interact with each resource type. I've tried to standardize the naming of those methods, added typehints and docblocks so that everything is well documented and clear. There are some BC breaks (e.g. the delete methods do not return boolean anymore). I've also added the deprecation warning to all methods that should be removed in a later release

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.4%) to 21.319% when pulling 3992d369aa4e7058952a12725325275311557ba2 on ProntoPro:api-handler-refactoring into 6940a94f8f299442e45adc4250cad2a65eae717c on loopline-systems:develop.