search

loopline-systems / closeio-api-wrapper

PHP Wrapper to use the Close.io API
MIT License
14 stars 15 forks source link

Improve Travis CI setup and force CS rules #94

Closed ste93cry closed 5 years ago

ste93cry commented 6 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

With this PR I would like to improve the build time in Travis CI and its setup. I've reworked the configuration so that we use the stages feature and we cache the Composer directory to speed up things. I've also made Coveralls to run only if the build is successful as I think that knowing the code coverage when the build fails has no value

ste93cry commented 5 years ago

Build is now green. I've moved the code coverage step to its own stage that runs only after all the tests pass, so we avoid waiting uselessly and fixed all CS issues according to the PHP-CS-Fixer configuration. Indeed some rules are debatable but I think that applying them now or later doesn't really change much as you will anyway probably do it at some point and regardless of the rules there will always be a bit commit full of changes. I've isolated these changes in its own commit by the way to ease the review.