search

loopme / ios-united-sdk

Please meet our New United SDK. It combines multiple premium ads technologies with the highest performance and lean resource consumption.
Other
1 stars 2 forks source link

Remove the OMSDK from the codebase #121

Closed bzarzoza closed 2 weeks ago

bzarzoza commented 1 month ago

This PR removes the OMSDK from the LoopMe SDK. I have verified that the build script continues to function with these changes.

ValeriiLoopMe commented 3 weeks ago

Why you have removed LoopMeViewabilityManager? And maybe better remove it separately because it not related to OMID?

bzarzoza commented 3 weeks ago

It’s no longer used.

On Tue, Jun 4, 2024 at 5:08 AM ValeriiLoopMe @.***> wrote:

Why you have remove LoopMeViewabilityManager?

— Reply to this email directly, view it on GitHub https://github.com/loopme/ios-united-sdk/pull/121#issuecomment-2147373149, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMKWM2JC2SI7DPG7T4OBTZFWU4JAVCNFSM6AAAAABITNWOCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGM3TGMJUHE . You are receiving this because you authored the thread.Message ID: @.***>

-- _The above terms reflect a potential business arrangement, are provided  solely as a basis for further discussion, and are not intended to be and do  not constitute a legally binding obligation. No legally binding obligations  will be created, implied, or inferred until an agreement in final form is  executed in writing by all parties involved.

This email and any  attachments hereto may be confidential or privileged.  If you received this  communication by mistake, please don't forward it to anyone else, please  erase all copies and attachments, and please let me know that it has gone  to the wrong person. Thanks._

bzarzoza commented 3 weeks ago

And maybe better remove it separately because it not related to OMID?

It's good practice to remove unused code, we can always revert if needed.

ValeriiLoopMe commented 3 weeks ago
Screenshot 2024-06-04 at 16 47 11

I see the problem with IC demo app with SDK. SDK doesn't load ads

bzarzoza commented 3 weeks ago

I see the problem with IC demo app with SDK. SDK doesn't load ads

Thank you for flagging. Will investigate and reopen.

ValeriiLoopMe commented 3 weeks ago

You missed to remove properties: LoopMeOMIDVideoEventsWrapper *omidVideoEvents `LoopMeOMIDWrapper * omidWrapper'

Method: (LoopMeOMIDVideoEventsWrapper *)omidVideoEvents

Declaration: LoopMeOMIDWrapper