loot / fallout3

The Fallout 3 masterlist.
Creative Commons Zero v1.0 Universal
7 stars 9 forks source link

Add Tranquility Secrets -A Vault 112 mod- #436

Closed Superfly-Johnson closed 1 year ago

Superfly-Johnson commented 1 year ago

Added a few bash tags too, I'm not sure about Invent.Remove here however.

I would like to add a message telling people to use the latest version instead of the 1.4 version I added here, any suggestion?

MacSplody commented 1 year ago

Added a few bash tags too, I'm not sure about Invent.Remove here however.

Invent.Remove looks okay, some items are removed from a couple containers.

Actors.Voice for 000BD693. Scripts could be added for 000B364C and 0004E79C. Text A few descriptions are changed.

Relev isn't needed, as there are no changes to the Level or Count of a (LVLO) leveled list entrys.

If you aren't sure about tags, check the reference Wrye Bash Advanced Readme.

I would like to add a message telling people to use the latest version instead of the 1.4 version I added here, any suggestion?

Latest being 1.5 or the UUFO3P update?

Obsolete message if they have 1.4 instead of 1.5 and are not using UUFO3P. useVersion for the UUFO3P update, if they're using UUFO3P.

Superfly-Johnson commented 1 year ago
    # Version 1.4
      - crc: 0x98875EF4
    # Version 1.5
      - crc: 0xF26EF89D
    # Version 1.6
      - crc: 0xE86E729F

Is there any way to have a message pop up for update information? Like ver 1.5 probably shouldn't be used if you're running the UUFO3P

MacSplody commented 1 year ago

Is there any way to have a message pop up for update information? Like ver 1.5 probably shouldn't be used if you're running the UUFO3P

  - name: 'TranquilityEnhanced.esp'
    msg:
      - <<: *useVersion
        subs: [ 'Unofficial Fallout 3 patch' ]
        condition: 'active("Unofficial Fallout 3 Patch.esm") and (checksum("TranquilityEnhanced.esp", 98875EF4) or checksum("TranquilityEnhanced.esp", F26EF89D))'
Superfly-Johnson commented 1 year ago

TY for your help as usual MacSplody

Superfly-Johnson commented 1 year ago

I checked the mod again in Xedit armed with the wrye bash advanced readme and those are all the possible bash tags taht could apply to this mod. I don't think there's anything else I'd like to do with this PR

MacSplody commented 1 year ago

Changes I made, trying to get through as many pull requests as I can today. I outlined why I made the changes below.

  - name: 'TranquilityEnhanced.esp'
    url:
      - link: 'https://www.nexusmods.com/fallout3/mods/22115/'
        name: 'Tranquility Secrets -A Vault 112 mod-'
    msg:
      - <<: *obsolete
        subs: [ '[Tranquility Secrets](https://www.nexusmods.com/fallout3/mods/22115/) v1.5' ]
        condition: 'checksum("TranquilityEnhanced.esp", 98875EF4) and not active("Unofficial Fallout 3 Patch.esm")'
      - <<: *requiresResources
        subs: [ 'Tranquility Secrets v1.4' ]
        condition: 'not file("Music/TranquilityLane")'
      - <<: *useVersion
        subs: [ 'Unofficial Fallout 3 Patch' ]
        condition: 'active("Unofficial Fallout 3 Patch.esm") and (checksum("TranquilityEnhanced.esp", 98875EF4) or checksum("TranquilityEnhanced.esp", F26EF89D))'
    tag:
      - Actors.ACBS
      - Actors.AIPackages
      - Actors.Stats
      - Actors.Voice
      - Delev
      - Factions
      - Invent.Add
      - Invent.Remove
      - Names
      - Scripts
      - Text
    clean:
      # Version 1.5 Vanilla
      - crc: 0xF26EF89D
        util: 'FO3Edit v4.0.4'
      # Version: 1.6 UUFO3P
      - crc: 0xE86E729F
        util: 'FO3Edit v4.0.4'

Reordered message aliases, kept in alphabetical order as it's easier for contributors to follow.

Changed patchUpdateAvailable to obsolete, as it seems like a better fit. Since it's a replacement ESP and not a separate patch file.

Added requires resource message, some users do install mods without reading, so they might miss that they need the files from 1.4 archive. Checking that one of the resource folders is present.

    msg:
      - <<: *useVersion
        subs: [ 'Unofficial Fallout 3 Patch' ]
        condition: 'active("Unofficial Fallout 3 Patch.esm") and (checksum("TranquilityEnhanced.esp", 98875EF4) or checksum("TranquilityEnhanced.esp", F26EF89D))'
      - <<: *patchUpdateAvailable
        subs: [ '[Tranquility Secrets -A Vault 112 mod-](https://www.nexusmods.com/fallout3/mods/22115/)' ]
        condition: 'checksum("TranquilityEnhanced.esp", 98875EF4) and not active("Unofficial Fallout 3 Patch.esm")'

Invent.Add required as this mod adds items to containers and inventories.

      - Invent.Add

Removing 1.4 as we usually only keep the cleaning data for the latest versions. Updated comment alignment and added detailed name of each version.

Also add a newline to separate the two mods.

    clean:
    # Version 1.4
      - crc: 0x98875EF4
        util: 'FO3Edit v4.0.4'
    # Version 1.5
      - crc: 0xF26EF89D
        util: 'FO3Edit v4.0.4'
    # Version 1.6
      - crc: 0xE86E729F
        util: 'FO3Edit v4.0.4'
MacSplody commented 1 year ago

Thanks.