loot / libloot

A C++ library for accessing LOOT's metadata and sorting functionality.
GNU General Public License v3.0
32 stars 12 forks source link

Version condition caching lowercases version string to compare against #34

Closed Ortham closed 6 years ago

Ortham commented 6 years ago

This is not correct behaviour, as semver states that

identifiers with letters or hyphens are compared lexically in ASCII sort order

so case should be preserved. This is unlikely to cause issues in reality as it's a small corner case, but good fixes would be:

Ortham commented 6 years ago

This was initially done by case-sensitive condition caching in 2c079731a5482832c44f84bf2278a8a5a905af23, then by more granular caching introduced as part of loot-condition-interpreter in 1c025a4fba60208086bbfbc87cb77ed41ada362f.