search

loot / libloot

A C++ library for accessing LOOT's metadata and sorting functionality.
GNU General Public License v3.0
32 stars 12 forks source link

Remove PluginMetadata::GetLowercasedName() and move std::hash specialisation out of API #53

Closed Ortham closed 4 years ago

Ortham commented 5 years ago

PluginMetadata::GetLowercasedName() is no longer useful, and the specialisation of std::hash for PluginMetadata isn't used in the public API, only by MetadataList.

Also remove PluginMetadata::GetNormalizedName() as it's only used by the std::hash specialisation, and is otherwise an implementation detail.

As an intermediate non-breaking change, it might be worth reimplementing PluginMetadata::GetLowercasedName() using the Win32 API / ICU to fix its behaviour being locale-sensitive (which is a bug, so OK to change).

Ortham commented 4 years ago

Done in 6a1184c8da735fce92639e2a6e985e9855e64465.