PluginMetadata enabled field doesn't do anything

loot / libloot

A C++ library for accessing LOOT's metadata and sorting functionality.

GNU General Public License v3.0

32 stars 11 forks source link

PluginMetadata enabled field doesn't do anything #63

Closed Ortham closed 4 years ago

Ortham commented 4 years ago

It's serialised and deserialised correctly, but isn't checked during sorting logic...

Also, merging metadata just replaces the existing value, so it's not possible to tell which metadata in a merged PluginMetadata object came from a disabled object and which did not. This is a complicated problem to solve, so maybe just drop the ability to disable metadata entries since it apparently wasn't missed.

Ortham commented 4 years ago

Done in d9788b70fc0e0d03c77122ec41c0276b3dc13fe6.