search

loot / libloot

A C++ library for accessing LOOT's metadata and sorting functionality.
GNU General Public License v3.0
32 stars 12 forks source link

libloot release archive naming #87

Closed NicBOMB closed 1 year ago

NicBOMB commented 1 year ago

I am working on https://github.com/Nexus-Mods/node-loot/pull/6 and noticed the github actions workflow for Releases appears to have the Snapshot version naming described in the README instead of the Release version naming as seen in LOOT releases. GIT_DESCRIBE=$(git describe --tags --long --abbrev=7) should be GIT_DESCRIBE=$(git describe --tags --long --abbrev=0) among other changes. Not having the commit suffix and duplicate tag in the output name would make incorporating Releases downstream much easier.

Ortham commented 1 year ago

Commit 4636b95c3e7123a5c044a64c92cf8c2e4342a122 changes the release version to be just the tag name, so the next release's artifacts will have the same kind of format as LOOT release artifacts do.

Ortham commented 1 year ago

Closing this as the v0.18.3 release uses the new naming convention.