loot / loot.github.io

The website and meta issue tracker.
https://loot.github.io
GNU General Public License v3.0
12 stars 9 forks source link

Site redesign #34

Closed Ortham closed 9 years ago

Ortham commented 9 years ago

The site looks a bit crummy, it still has the "throw something together quickly" layout I started with. Since LOOT v0.7's UI is going to be based on Material Design, it would be nicely consistent if the site were redesigned with the same style.

I've started this work in the material-redesign branch. Still to do are:

The site redesign doesn't need to be coordinated with the v0.7 release, it can go live as soon as it's done.

Ortham commented 9 years ago

Bah humbug there are styling issues in Firefox and IE. I've gotten most of the Firefox ones fixed, but still to fix are:

Ortham commented 9 years ago

OK, now for Material Design double-checking. The core elements aren't specifically Material Design, but they do overlap, so they should be checked too.

Also a few other things, like:

The MD spec uses units of density independent pixels (dp) for layouts and scaleable pixels (sp) for font sizes. I'm using the following mapping:

Ortham commented 9 years ago

A lot of polish was applied in 52f5b3ee98e79ffd6e453de2787d2f8aab22ae48, which ticked most of the boxes above.

Ortham commented 9 years ago

I tried to switch to a true MD grid layout for the contributor cards in 85550a52f777f006001bd14baf089dc6a57851fb, but on my phone the cards' touch area was offset from the content, and it caused the grid to look and behave weird, so I've reverted the changes.

To switch between the true grid and the inline list, the width CSS needs to be removed from the #contrib > paper-item selector in credits.html, and credits.js updated to add a grid class and vertical attribute to the paper-item, removing the horizontal and center attributes. Then just copy across the block of grid CSS added in the above commit.

Ortham commented 9 years ago

I've done as much as I want to with the input and dropdown elements in 1fff0ba607b4dbc6ad7ee9c555168887c8bbd9fa. The spacings in the MD spec just doesn't match the pictures they give, and looks ridiculous.

Ortham commented 9 years ago

Bah humbug, I tested 9e5908d0f4db7674aef264b364018b81b2e93661 over my local network on my phone, and it all worked fine, so I pushed it, and the online page displays badly again. It looks like there's extra padding within the paper-item for each contributor card.

I've had to revert the changes again, because I can't get the Chrome remote debugging to see my phone...