search

looterz / grimd

:zap: fast dns proxy that can run anywhere, built to black-hole internet advertisements and malware servers
MIT License
1.38k stars 108 forks source link

Update golang version to 1.18 #92

Closed soulteary closed 2 years ago

soulteary commented 2 years ago

@looterz wow ,I didn't even have time to write an issue with a clear purpose...

looterz commented 2 years ago

Sorry about that, was a bit quick on the gun on mobile - been meaning to update to 1.18 for awhile now

soulteary commented 2 years ago

Here is an additional explanation why the version of x/sys was upgraded, Avoid confusion for latecomers.

After the upgrade of golang 1.18, it will cause the project to fail to start on macOS.

https://github.com/google/go-jsonnet/issues/596

Currently, this problem has been officially corrected earlier. like this:

https://github.com/golang/go/issues/49219

Simply put, if we encounter this kind of problem, we only need to execute

go get -u golang.org/x/sys

That's it, no side effects

soulteary commented 2 years ago

Sorry I didn't explain clearly.

I think I should follow the rules and submit issues first, then PRs.

I'm actually quite happy because you didn't even need me to explain why you upgraded to go 1.18 and made changes to a module, thank you for your trust. @looterz 🍻