search

loov / jsfx

Javascript Sound Effect Generator
MIT License
572 stars 49 forks source link

small noise on generated sounds #2

Closed gre closed 13 years ago

gre commented 13 years ago

Hi,

Most of generated sounds have a little noise in background (like a radio noise). Do you know how to remove it ? I've tried a low pass filter and high pass filter but it's still present. Is it fixable with a property of the library or is it a real bug ?

Thanks for this awesome library. gre

egonelbre commented 13 years ago

I'm guessing it has to do with aliasing. Try the generation before/after increasing Super Sampling Quality. This should reduce the noise although it will increase the generation time.

If that has no effect on it, I'll take a closer look.

gre commented 13 years ago

I'm still getting the problem by increasing the super sampling quality.

Here is my case : http://bit.ly/dQE7y6

Regards, gre

gre commented 13 years ago

Have you found the source of that noise? Here is a little experiment I'm working on http://greweb.fr/melody/ but I can't find a way to solve the noise problem.

egonelbre commented 13 years ago

Hey... thanks... that helped to solve the problem. It was a nice example where it broke. Essentially it broke when the sound was too quiet. After some debugging I tracked it down. It was due to 8bit audio.

I added support for 16bit audio, and this seems to fix the problem.

egonelbre commented 13 years ago

Also it's quite nice experiment. :)

gre commented 13 years ago

It works like a charm.

Thanks a lot for that fix.

And I'll keep you inform of my (unfinished now) experiment ;)

Regards, gre

On Sun, Jun 26, 2011 at 9:01 PM, egonelbre < reply@reply.github.com>wrote:

Also it's quite nice experiment. :)

Reply to this email directly or view it on GitHub: https://github.com/egonelbre/jsfx/issues/2#issuecomment-1442161