search

looxonline / Marlin

This is a customized Marlin repo with firmware for various BIQU 3D printers available. Browse the readme to see if there is something here for you.
http://marlinfw.org
GNU General Public License v3.0
78 stars 18 forks source link

Renamed Hal to HAL to comply with general naming scheme and to make i… #16

Open Laplace-Transformer opened 3 years ago

Laplace-Transformer commented 3 years ago

Compilable on clean Linux on VS Code with Auto Marlin Builder

Requirements

None that wasn't previous in the build. VS Code + PlatformIO/Auto Marlin Builder

Description

Benefits

Configurations

Related Issues

ellisgl commented 3 years ago

Standard naming conventions, are you nuts? LOL

Laplace-Transformer commented 3 years ago

Thank you for your comment. If you have an issue with the PR or a constructive criticism please post it. I've made this PR as Luke's build didn't currently work on Unix based systems without macros to ignore path case sensitivity. Either I should update HAL to Hal in some of the files or I could rename the folder to HAL (like it is done in base Marlin) and change some of the files as well.

I'm just trying to help.

ellisgl commented 3 years ago

@Laplace-Transformer I was trying to funny. I very much welcome changes that get things into standards that are set in place and appreciate what you have done. In my programming job, it's hard thing to do to go back and fix when it's out in the wild.

ellisgl commented 1 year ago

@looxonline any plans on merging this in? Also updating the base marlin stuff?

looxonline commented 1 year ago

@looxonline any plans on merging this in? Also updating the base marlin stuff?

Updating the base Marlin is not feasible while retaining the BTT UI. I am going to look at updating the base while also retaining the ability to switch between the BTT UI and the SBC UI.