search

lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
192 stars 77 forks source link

Fix hash for ogre on Iron #308

Closed Programmerino closed 1 year ago

Programmerino commented 1 year ago

It seems like the hash in the Iron overrides.nix file for ogre has become mismatched. This updates it to match the latest hash, after which it builds correctly.

lopsided98 commented 1 year ago

oh no... this means something in that mess is non-reproducible

hacker1024 commented 1 year ago

Perhaps we should merge first and ask questions later?

Anyway, I guess this sort of thing was bound to happen eventually. Until content-addressable derivations are available, hashing the output of a derivation always carries some risk. Maybe the issue is the mtime as explained here?

lopsided98 commented 1 year ago

It's not really inevitable; fixed output derivations work fine as long as you take care of all the non-reproducible parts.

In this case, I forgot that patching Components/Overlay/CMakeLists.txt would create a non-deterministic timestamp.