lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
173 stars 69 forks source link

buildEnv: Disable redundant fixup operations #335

Closed hacker1024 closed 6 months ago

hacker1024 commented 7 months ago

The fixupPhase is needed for shell hooks and input propagation, but other things like RPATH shrinking and shebang patching are not needed, as the original packages should have already been fixed up.

This significantly reduces buildEnv build times. The shebang patching in particular is quite slow.

wentasah commented 7 months ago

This makes sense. I've verified that it doesn't break my (ROS 2) projects.