Closed mikepurvis closed 4 months ago
Related to this, I would suggest adding a protobuf
key to the ignition scope and pulling from it by default in the ignition packages. I'm currently porting us forward to nixos-23.11 and having to override protobuf individually in several places in order to achieve binary coherence:
ignition = prev.ignition // {
protobuf = final.pkgs.protobuf3_20;
msgs5 = prev.ignition.msgs5.override {
inherit (final.ignition) protobuf;
};
transport8 = (prev.ignition.transport8.override {
inherit (final.ignition) protobuf;
}).overrideAttrs (old: {
# SES-3788: Not strictly a runtime dependency, but adding it as one here for development ease.
propagatedBuildInputs = old.propagatedBuildInputs ++ [ final.ignition.cmake2 ];
});
};
gazebo_11 = prev.gazebo_11.override {
boost = final.ros-boost;
inherit (final.ignition) protobuf;
};
If that's an acceptable change, lmk and I'll send a separate PR for it.
This aligns it to the other ones:
For now I'll pass it instead using the
ignition
scope, but it would be nice to have this consistent.