search

lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
173 stars 69 forks source link

Broken package definition due to quote in package metadata #356

Closed koalp closed 3 months ago

koalp commented 4 months ago

In the sick_scan_xd package, there are quote in the license definition.

it results in a broken license definition in the corresponding nix package :

https://github.com/lopsided98/nix-ros-overlay/blob/9f53d85d2a20447f67048a85e5e79e8753dce327/distros/humble/sick-scan-xd/default.nix#L22-L25

It may be an issue for any package with quote in metadata but I haven't found another one yet.

What would be the best way to solve the issue ? Open a PR in sick_scan_xd or modify superflore-gen-nix to strip quotes ?

lopsided98 commented 4 months ago

The correct solution is to make superflore escape quotes properly.