- humble/ompl: patch the .pc file with cmake full paths

lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager

Apache License 2.0

174 stars 68 forks source link

- humble/ompl: patch the .pc file with cmake full paths #374

Closed akssri-sony closed 3 months ago

wentasah commented 3 months ago

Hi, thanks for the patch. This this has already been fixed upstream, but the fix didn't propagate to ROS releases yet. It would be better to apply the patch to all ROS 2 releases in ros2-overlay.nix instead of just to humble. I tested that ompl in humble, iron and rolling is broken.

akssri-sony commented 3 months ago

Ah, I was going to make a upstream PR; but good to know that it's fixed.

I've moved the patch to ros2-overlay.nix.

lopsided98 commented 3 months ago

Noetic needs this as well, and I also I prefer to fetch patches from their upstream source where possible. I went ahead and did that in dc5a4a3fa52f98972708abb996e73e843c08a09b

akssri-sony commented 3 months ago

ah, makes sense; thanks.