search

lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
174 stars 68 forks source link

Fix jsk-recognition-msgs on noetic #407

Open kjeremy opened 1 month ago

kjeremy commented 1 month ago

This contains two fixes:

  1. The first is that ROS_DISTRO is read from the environment in CMakeLists.txt. The variable is only available when ros-environment is included as a build input. I'm not sure how this worked before. (https://github.com/jsk-ros-pkg/jsk_recognition/pull/2836)

  2. The second build fix is removing catkin_python_setup from CMakeLists.txt (https://github.com/jsk-ros-pkg/jsk_recognition/pull/2829)

Fixes #406

kjeremy commented 1 month ago

@lopsided98 should we be specifying ROS_DISTRO, ROS_VERSION, and ROS_PYTHON_VERSION at build time?

wentasah commented 1 month ago

Hi, I'm not that much familiar with ROS 1 and not sure why are you asking, but the answer is likely yes. There are packages that use these variables at build time to decide how to build their code, e.g. which quirks need to be applied for compatibility with different ROS versions/distributions.

kjeremy commented 1 month ago

@lopsided98