lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
174 stars 68 forks source link

Python qt bindings support both #416

Open Pleune opened 4 weeks ago

Pleune commented 4 weeks ago

I have been bounding around trying to get all of the pyqt stuff to work across all of the distros for a while now... and I think this is my final solution. It seems to keep everything happy, and works even for the most current versions of everything, without requiring any huge overrides, or any patches that will break when files are updated upstream.

Some packages need specifically pyqt or pyside to be loaded by python-qt-binding. This changes the overrides to support both.

Annoyingly, in recent python-qt-binding releases, sip_configure.py, the cmake helper script, rewrites QtCoremod.sip, which is outside of the nix build area and causes a build failure. See https://github.com/ros-visualization/python_qt_binding/commit/e78372fd63eda527c9fad5fcdab8ca31eb3f36d2

This is the same patch that is applied from the AUR here. So sed patch out these changes. Then move the ros1 rviz patch to distro-overlay.nix to apply to everything.

Tested with: