search

lopsided98 / nix-ros-overlay

ROS overlay for the Nix package manager
Apache License 2.0
174 stars 68 forks source link

Update all VRPN packages to a working version #418

Open Pleune opened 2 weeks ago

Pleune commented 2 weeks ago

Importantly, includes the changes under commits titled "deprecate CMAKE_HAVE_THREADS_LIBRARY", which allow its FindVRPN.cmake file to work on the newest cmake versions.

Other changes that are unique to the ros2-gbp/vrpn-release repo are needed, so don't pull from upstream.

wentasah commented 2 weeks ago

Hi! Can you be more specific what is not working in this package? AFAICS, the package compiles fine. So I guess the problems are at run time. Does to problem appear in all ROS versions or only selected ones?

Pleune commented 1 week ago

The vrpn package does actually compile fine, but the FindVRPN.cmake file it installs does not work with very recent versions of cmake, causing dependent packages from building.

This is because the mentioned used variable was undocumented, and was also removed in a recent cmake version. There is simply another equivalent and properly supported variable that should be used instead. The last few versions of the vrpn ros releases have a patch applied for this, even though it is not actually used until jade it seems. My guess is that Ubuntu/Debian do not use new enough cmake yet for it to matter. I did not bother to check what version of cmake is breaking.