search

lopspower / CircularImageView

Create circular ImageView in Android in the simplest way possible
Apache License 2.0
1.95k stars 413 forks source link

Changed attribute names to be less generic to avoid conflicts #50

Closed BWMuller closed 8 years ago

BWMuller commented 8 years ago

Changed attribute names to less generic versions to avoid naming conflicts with other libraries such as Instabug. Moved library dependant classpaths to the library

lopspower commented 8 years ago

I don't understand the reason for your request to pull. I already changed attribute names to avoid conflicts.

BWMuller commented 8 years ago

Pull the library a few hours ago. The style attribute names eg. civ_border are quite generic. There are several libraries that contain a CircleImageView with attributes starting in civ. If multiple libraries have the same attribute names conflicts occur.

lopspower commented 8 years ago

What is the interest of adding two libraries to make circular images in the same project?

BWMuller commented 8 years ago

Some libraries include their own versions of features such as the Circular Image View however they implement them horribly or do not make them public. This then causes conflicts with other such libraries.

In this case Instabug has a Circlular Image View included in its libraries, however it breaks horribly and is very buggy as is. Also your library is exactly what I am looking for.