search

lopspower / CircularImageView

Create circular ImageView in Android in the simplest way possible
Apache License 2.0
1.95k stars 413 forks source link

Please remove application tag attributes #79

Closed ymytkalyk-waverleysoftware closed 6 years ago

ymytkalyk-waverleysoftware commented 7 years ago

Don't pollute application tag with attributes, e.g.

<application
        android:allowBackup="true"
        android:supportsRtl="true" />

Should be replaced with

<application/>

Because that adds the tags to main manifest while merging the library and conflicts with supportsRtl=false", etc.

lopspower commented 6 years ago

Fix on https://github.com/lopspower/CircularImageView/commit/74a62546086287f3d16c0f2a59a60f7e5d153bfd