loqui / im

Loqui IM allows you to use all your chat accounts in just one FirefoxOS or Ubuntu Touch app.
https://loqui.im
304 stars 112 forks source link

AGPL license text (Settings Info) not visible/access able #458

Closed ghost closed 10 years ago

ghost commented 10 years ago

I noticed after the additional changelog link #455 is the text of the AGPL not access able at all. It is not possible to scroll down to the license text.

info

No AGPL license text visible info_no_agpl_text

before #455 info_old

Gioyik commented 10 years ago

@bdcomp Do you know what could happen?

bdcomp commented 10 years ago

No, and in fact, I am curious how a simple html line of code could do this.

Although, while the Info screen is of "scroll" css class, there is no such class in the index.css

ghost commented 10 years ago

i am not sure why but adding a <p>-tag fix this problem

<p><small data-l10n-id='FreeSoftware'>This program is free software; you may redistribute and/or modify it under the terms of the GNU Affero General Public License (AGPL 3) as published by the Free Software Foundation.</small></p>

And this problem is not caused by adding a html line, it only gets visible through it, as i couldn't reach the text before if the screen is toppled

bdcomp commented 10 years ago

Done!

@aesedepece I am still wondering about the "scroll" css class. Shouldn't this be exist?

ghost commented 10 years ago

@bdcomp

The fix #460 does not fix the problem with a toppled screen. I can't access the text at all.

The scroll-class is already added but something within the simple-class might be the problem

<article id='info' class='simple scroll'>
bdcomp commented 10 years ago

@bobcanthelpyou What do you mean by "toppled screen"?

ghost commented 10 years ago

that screen: info_no_agpl_text

aesedepece commented 10 years ago

The scroll class is defined in /style/loqui/chungo.css as follows:

.scroll {
    overflow: auto;
    will-animate: scroll;
}
ghost commented 9 years ago

This problem appears again and is caused by height: calc(100% - 6rem)!important; within index.css. If i disable the height, everything is fine on the Info page

Why is the height calculated in that way?

section.extended article {
  top: 6rem;
  height: calc(100% - 6rem)!important;
}