loqusion / hyprshade

Hyprland shader configuration tool
MIT License
210 stars 6 forks source link

Screen shader parser: Screen shader parse failed #39

Open vitezprchal opened 4 weeks ago

vitezprchal commented 4 weeks ago

When using the main branch of Hyprshade, shaders fail to parse correctly.

Steps to Reproduce

  1. Check out the main branch of the Hyprland repository.
  2. Attempt to run Hyprland with custom shaders (blue filters).
loqusion commented 4 weeks ago

Please provide your configuration file (hyprshade.toml), the command(s) you ran (e.g. hyprshade on blue-light-filter), and the command output.

loqusion commented 3 weeks ago

Actually, did you set decoration:screen_shader to the path to blue-light-filter.glsl.mustache manually?

vitezprchal commented 3 weeks ago

I managed to fix it by copying https://github.com/loqusion/hyprshade/tree/3.2.1/shaders into my shaders directory instead of using shaders from master branch. I used the default example config that is provided in code.

loqusion commented 3 weeks ago

The shaders on the main branch are actually Mustache templates, so they will only work when rendered into GLSL. Hyprshade on the main branch does this with hyprshade on, hyprshade toggle, etc. so that shaders are configurable (see the 4.0.0 README for more info).

Did you activate the shader with Hyprshade on the main branch, with Hyprshade pre-4.0.0, or some other way?

vitezprchal commented 3 weeks ago

At first I copied config from the master branch and activated the shaders using hyprshade on blue-light-filter. It didn't produce any relevant output, only displaying 'parse failed.' Eventually, I managed to fix it using the method I described earlier here.

loqusion commented 3 weeks ago

Was the hyprshade executable from the main branch or was it a stable version? If main, this could be a bug.

vitezprchal commented 3 weeks ago

It was a stable version, it was my mistake because of copying shaders from main branch.

loqusion commented 3 weeks ago

Shaders should not need manual installation, they are included in the wheel and Hyprshade detects them automatically. Did your installation of Hyprshade not include them?

vitezprchal commented 3 weeks ago

Since I'm using nixos, I didn't declare shaders path in my config. Instead, I manually placed it in my .config directory from github repo.