search

lora-aprs / LoRa_APRS_iGate

This is a LoRa APRS iGate/Digi based on an ESP32
https://www.lora-aprs.info
MIT License
348 stars 112 forks source link

Adding option to report RSSI & SNR in the packet #139

Closed OK1FWG closed 2 years ago

OK1FWG commented 2 years ago

Hello, I added the option to add RSSI & SNR info in to the packet. This is optional, based on the boolean value in the config. Hope it will be of use (I am very glad to have it).

peterus commented 2 years ago

As this is against the APRS standard (never change a text of a message) and it will increase the load dramatically of the APRS-IS servers (multiple iGates will create multiple different messages which will float the servers) i have to close this merge request and not merge it.

This idea was already log time ago and there was already a lot of discussion in the german telegram lora aprs group. But in the end i decided that i will strictly follow the APRS standard and will never include this "feature". There are better ways to get this information like on a webpage.

But, thank you very much for your work! I hope that you will understand it! 🙂

OK1FWG commented 2 years ago

Hello Peter, I understand your point of view and have no problem with your attitude. I just made an effort based on the request and it was a challenge for me too. One important aspect for me was to make it optional, not to be hardcoded. There are still lots of things to learn. Have a nice and sucessful New Year 2022! 73, Willi, OK1FWG

---------- Původní e-mail ---------- Od: Peter Buchegger @.> Komu: lora-aprs/LoRa_APRS_iGate @.> Datum: 2. 1. 2022 18:37:28 Předmět: Re: [lora-aprs/LoRa_APRS_iGate] Adding option to report RSSI & SNR in the packet (PR #139) "

As this is against the APRS standard (never change a text of a message) and it will increase the load dramatically of the APRS-IS servers (multiple iGates will create multiple different messages which will float the servers) i have to close this merge request and not merge it.

This idea was already log time ago and there was already a lot of discussion in the german telegram lora aprs group. But in the end i decided that i will strictly follow the APRS standard and will never include this "feature". There are better ways to get this information like on a webpage.

But, thank you very much for your work! I hope that you will understand it! 🙂

— Reply to this email directly, view it on GitHub (https://github.com/lora-aprs/LoRa_APRS_iGate/pull/139#issuecomment-1003750158) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AIVTAUURRGXV3A3FDCKDSCTUUCENHANCNFSM5LD3JEMA) . Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub) . You are receiving this because you authored the thread. Message ID: <lora- @.***> "