Run dump_html on pre build on platformio

lora-gateway / esxp1302

An 8-channel ESP32 LoRa Gateway based on SX1302

Other

33 stars 17 forks source link

Run dump_html on pre build on platformio #12

Closed valcarcexyz closed 1 month ago

valcarcexyz commented 1 month ago

webpage.h was removed on refactor to generate it from the dump_html.py script. This script is only run when not building from PlatformIO, so I refactored the script to be able to call it also from the pre-run stage in PlatformIO. Keeps original behavior.

Related issues: #11

dennis4lora commented 1 month ago

Thanks a lot to @valcarcexyz for finding this problem as well as fixing it. I see no problem for the improvement. And also thanks to @danielkucera for the review.

To be honest, I am not so familiar with PlatformIO and VS Code, so I did not test it that way after the porting is finished. My mistake.

If you see any other problems or ideas for improvement, I am happy to know them. Thanks.