search

lora-gateway / esxp1302

An 8-channel ESP32 LoRa Gateway based on SX1302
Other
33 stars 17 forks source link

Check if GPIO pins are set to something, otherwise ignore them #20

Closed tjfsteele closed 1 week ago

tjfsteele commented 2 weeks ago

With the code as written a gateway built without buttons and without POWER_EN connected due to use of minipcie module always starts in Soft AP mode because it thinks Button 1 is pressed, and tries to power up the gateway with POWER_EN.

danielkucera commented 2 weeks ago

I would like it more as preprocessor directive. Other than that, it looks okay.

dennis4lora commented 1 week ago

@tjfsteele

Thanks for your fix.

When this project grows out of its original design, small bugs are unavoidable. So reporting issues are welcome, submit PR are even more appreciated. :smile:

I would like it more as preprocessor directive.

I think the preprocessor way makes it more explicit, while this PR hides this config and makes it "simpler". So I'd like to merge this PR now, and if necessary, we can change it in the future easily.