Open lrljoe opened 1 year ago
@lrljoe, I apologize for such a late reply! For some reason I don't get notifications from this repository.
Q1: The ranges are merging using a script, but I'm not sure if this is the optimal way.
Q2: Yes, of course. If you have something to suggest - send PRs (preferably 1 provider = 1 PR)
Q3: I think this is easily done by changing the arguments for the sort
command in each downloader + merge. Right now only -h
is used
Q4: What's it for? It seems easy enough to convert to json from txt files on your own.
Q5: Which ones sources are we talking about? I don't mind if the ranges from this repository are used wherever needed.
@lrljoe ,
Q3: will be corrected after https://github.com/lord-alfred/ipranges/commit/e34eb665f7ffebefd090004577ebcd5794d1d8fb
Firstly, thanks for doing this!
Few questions
Q1
Did you resolve the issue of merging ranges?
Q2
Are you open to some contribs for additional providers?
Q3
What are your thoughts on reordering the merged txt file to be slightly cleaner for human eyes
E.g. Current
Proposed
Q4
Are you open to an extra JSON approach for the "all merged" files that includes the provider name?
Q5
I'm looking at utilising this in an open source Laravel Package, so it'd be good to be able to contribute a few sources. You happy with that?