lord-cyclone100 / pokedex

A pokedex built using pokeapi

https://pokedex-ten-livid.vercel.app/

0 stars 7 forks source link

Closed ohmschrodinger closed 2 days ago

ohmschrodinger commented 3 days ago

7

@lord-cyclone100 please let me know if any adjustments are needed 😄

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pokedex	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 1:40pm

lord-cyclone100 commented 2 days ago

gr8 work!!! But I suggest some changes.....

for the pokemon card, apply the hover and shadow effect for the pokemon image and not the card......use drop shadow instead of box shadow so that the shadow effect is applied wrt to the pokemon outlines.
Also it is not advised to use pure black and pure white colors (#000 and #fff) in any website. I saw somewhere in css u gave pure white color. pls revert back to the original one.

Make these changes then I shall merge. Also look at the comments i left on ur issue #7

ohmschrodinger commented 2 days ago

Okay cool! i'll do the necessary changes.

ohmschrodinger commented 2 days ago

I've made the changes as you said

changed the pure white color to #f7f7f7
updated the hover effect so that the pokemon-image gets the shadow effect instead of the whole card.

lord-cyclone100 commented 2 days ago

Amazing work @ohmschrodinger Keep it up!!! I am merging